icgc-argo / argo-dictionary

Development of the ARGO Data Dictionary
https://docs.icgc-argo.org/dictionary
GNU Affero General Public License v3.0
2 stars 1 forks source link

409 chemo dose exception #410

Closed hknahal closed 1 year ago

hknahal commented 1 year ago

Related to https://github.com/icgc-argo/argo-dictionary/issues/409

To test:

hknahal commented 1 year ago

Tested on DEV using HNAHAL-CA

Test case 1: Missing dose when dose units have been submitted If chemotherapy_drug_dose_units has an enum submitted from the dictionary (ex. chemotherapy_drug_dose_units = mg/m2) and prescribed_cumulative_drug_dose and actual_cumulative_drug_dose fields are left empty, the validation should fail.

Result: Validation fails as expected dev_chemo_invalid_submission

Test case 2: Dose field(s) are submitted when chemotherapy_drug_dose_units has a clinical exception value of Not applicable If chemotherapy_drug_dose_units has a clinical exception so that chemotherapy_drug_dose_units = Not applicable, but both/either prescribed_cumulative_drug_dose and actual_cumulative_drug_dose fields are submitted, the validation should fail.

Result: Validation fails as expected dev_chemo_invalid_when_exception

Buwujiu commented 1 year ago

Tested in Dev HNAHAL-CA, working as expected!