icgc-argo / argo-docs

User documentation site for the ICGC-ARGO Data Platform
https://docs.icgc-argo.org/
GNU Affero General Public License v3.0
3 stars 3 forks source link

Investigate docusaurus' magic box of routing so links don't break #258

Closed kcullion closed 4 years ago

kcullion commented 4 years ago

https://drive.google.com/file/d/12a2EcMRPLtcOrjogjCPVXWxkGE77_wfF/view

Problem as seen in video

kcullion commented 4 years ago

note: for launch, I am going to update all the links to the absolute path and see if that fixes this for now.

Also came across this in the template file...maybe they do want the .md extension when linking to a file

2020-05-29_1544
ciaranschutte commented 4 years ago

@kcullion you are correct. trailing slash is breaking links. Netlify adds it with it's Pretty URL setting.

ciaranschutte commented 4 years ago

https://github.com/facebook/docusaurus/issues/2394

kcullion commented 4 years ago

not so pretty netlify...not so pretty. I saw it happening on qa too, so to be safe I did the update to all urls on the docs site.

ciaranschutte commented 4 years ago

https://v2.docusaurus.io/docs/deployment#deploying-to-netlify @kcullion should be fixed now. I changed the netlify setting

please verify :)

kcullion commented 4 years ago

@ciaranschutte when I go to a netlify link that I had in my browser history, this slash doesn't seem to get added. Is the QA site also something that will update when new settings get merged? As I still see it happening on pages like https://docs.qa.argo.cancercollaboratory.org/docs/submission-overview

kcullion commented 4 years ago

@rosibaj I feel like we can merge this :)

rosibaj commented 4 years ago

moved to awaiting release!

rosibaj commented 4 years ago

on production