Closed rosibaj closed 4 years ago
@rosibaj is adding the latest version number to the end of the file name part of this ticket? Like donor_v0_1.tsv, sample_registration_v0_1.tsv
(I wonder if this looks confusing...especially when say sample registration file hasn't changed but the file name says sample_registration_v11_1.tsv)
it is possible to have . in file names, so we have options, couple I'd be happy with:
donor-v0.1.tsv
donor-v0_1.tsv
ok cool thanks @joneubank ...guess my question would be is it confusing to see a file that has never changed but the version number in the title keeps changing? I'm torn, because it's nice to see the version somewhere - like maybe in this message:
I might be wrong... clinical might reject files with . in the name (even if its a valid filename)... need to confirm. Until then, i'd use the donor-v0_1.tsv
formatting.
@kcullion that is not part of this ticket - we will need to create a different ticket for that one.
ticket not ready yet, but will be here: https://github.com/icgc-argo/argo-clinical/issues/363
@rosibaj download all endpoint in gateway doesn't necessarily link up with schemas on page
@ciaranschutte this should line up with the dictionary on production (0.2). It wo t line up with the QA gateway. Once deployed, will it point at QA or prod gateway api?
[x] Fix the Styling on the top file template button
[x] Hookup all templates download button (should be available from the gateway)
[x] Hookup per/file template download button
[x] Disable the download buttons if the latest dictionary version is not selected (tool-tip with informational text letting the user know why disabled)