icgc-argo / argo-docs

User documentation site for the ICGC-ARGO Data Platform
https://docs.icgc-argo.org/
GNU Affero General Public License v3.0
3 stars 3 forks source link

Data Hookup: File Templates Button #69

Closed rosibaj closed 4 years ago

rosibaj commented 4 years ago

image

kcullion commented 4 years ago

@rosibaj is adding the latest version number to the end of the file name part of this ticket? Like donor_v0_1.tsv, sample_registration_v0_1.tsv

(I wonder if this looks confusing...especially when say sample registration file hasn't changed but the file name says sample_registration_v11_1.tsv)

joneubank commented 4 years ago

it is possible to have . in file names, so we have options, couple I'd be happy with:

donor-v0.1.tsv donor-v0_1.tsv

kcullion commented 4 years ago

ok cool thanks @joneubank ...guess my question would be is it confusing to see a file that has never changed but the version number in the title keeps changing? I'm torn, because it's nice to see the version somewhere - like maybe in this message:

Screen Shot 2020-01-30 at 11 34 30 AM
joneubank commented 4 years ago

I might be wrong... clinical might reject files with . in the name (even if its a valid filename)... need to confirm. Until then, i'd use the donor-v0_1.tsv formatting.

rosibaj commented 4 years ago

@kcullion that is not part of this ticket - we will need to create a different ticket for that one.

ticket not ready yet, but will be here: https://github.com/icgc-argo/argo-clinical/issues/363

ciaranschutte commented 4 years ago

@rosibaj download all endpoint in gateway doesn't necessarily link up with schemas on page

rosibaj commented 4 years ago

@ciaranschutte this should line up with the dictionary on production (0.2). It wo t line up with the QA gateway. Once deployed, will it point at QA or prod gateway api?