icgc-argo / dac-api

Development of the Data Access Control API
GNU Affero General Public License v3.0
0 stars 0 forks source link

Revisions email not sent to applicant when only signature section is requested #402

Closed anncatton closed 1 year ago

anncatton commented 1 year ago

The "Your Application has been Reopened for Revisions" email is not sent to the applicant when an application is opened for revisions on the Signature section only. This is because the app state in this scenario is SIGN AND SUBMIT to allow the signature section to be enabled, but the email is not triggered when the app is in this state.

Solution: Add a email trigger to onStateChange in the SIGN AND SUBMIT case when signature is only section that has revisions requested.

b-f-chan commented 1 year ago

Released to prod, prod testing not possible for OICR team, hence we will close this ticket, and open new issues if any are found by users in production.