🐛 Collaborator section has multiple bugs

[kcullion]

Describe the bugs

There are some weird things happening in the collaborators section/ethics sections. Logging them all here for investigation

• [x] When filling out a collaborator and adding them to the table, the table of contents should be checked off - but you have to move away from it in order for that section to be checked off

• [x] Also when a user doesn't add collaborators to the form, but fills out the rest of the form correctly, the collaborators used to automatically get checked off when the Sign and Submit section enables. That's not the case anymore - the user has to refresh the application to see that section checked off.

• [x] this modal may be related, but made a ticket: https://github.com/icgc-argo/dac-ui/issues/364

• [x] Sam found that clicking on the collaborator section leads to this error

• [x] There's also this error when clicking on ethics section that Sam found:

• [x] When adding a collaborator, it adds to the table, but when I go to add a new collaborator, the modal data isn't cleared

[justincorrigible]

The issue with the validation icon on the outline is happening because of how we're calling a different API endpoint for collaborators; which is not done inside the validation routine, and therefor doesn't have all the same abstracted functionality out of the box. i.e. That code needs to be duplicated for the section.

What needs to happen is fairly simple, though: - this https://github.com/icgc-argo/dac-ui/blob/develop/components/pages/Applications/ApplicationForm/Forms/index.tsx#L89 - which is an abstraction for this https://github.com/icgc-argo/dac-ui/blob/develop/components/pages/Applications/ApplicationForm/Forms/validations/index.ts#L418 - needs to be called from here https://github.com/icgc-argo/dac-ui/blob/develop/components/pages/Applications/ApplicationForm/Forms/Collaborators/index.tsx#L128

It's only a matter of passing that dispatch call (that changes showOverall) down to Collaborators' fetch.then, somehow. Hope this helps!

---

Found a better way to do this and will be executing on it.

[justincorrigible]

Coincidentally, I've found the value.map error while working on #361, and fixed it there.

[justincorrigible]

The issues with the modal form not getting cleared and the delete modal not showing the collaborator's name are resolved via #329

[justincorrigible]

Could not replicate the first error Sam found (Cannot convert undefined or null to object) at all. Must've been resolved with another ticket?

As a sidenote, I did notice if you save the email as the collaborator's first, and then go an add the email as the applicant's, API is not tagging the collaborator as invalid/errored the same way it does for Affiliation. Not sure there's a ticket for that already.

[kcullion]

Tested Aug 12/13

• Table of contents icon behaves as expected
• Don't see the undefined values anymore
• Modal is cleared after adding a new collaborator
• Errors that Sam found are resolved.

we just found some log errors in the console so I'm making a new ticket for @samrichca to resolve that. https://github.com/icgc-argo/dac-ui/issues/373

Regarding: As a sidenote, I did notice if you save the email as the collaborator's first, and then go an add the email as the applicant's, API is not tagging the collaborator as invalid/errored the same way it does for Affiliation. Not sure there's a ticket for that already We made a ticket for Ann during sprint planning for this: https://github.com/icgc-argo/dac-api/issues/151

[kcullion]

Aug 16: working in staging

[rosibaj]

Aug 16, deployed to production (ui 0.23.1 / api 0.32.0)