[UI] DACO Admin ability to upload an approved pdf to an application

kcullion commented 3 years ago

Goal

On APPROVED applications, DACO admin needs the ability to upload the DACO approved pdf once it's signed by their office. When they upload it to the application, it will get added to the zip package and be available to download by the applicant. If DACO admin makes a mistake and uploads the wrong document, we will provide a Remove approved pdf button that will revert the download back to the signed zip package.

Endpoint ticket: https://github.com/icgc-argo/dac-api/issues/225

When no Approved pdf is uploaded

Zeplin: https://zpl.io/Vxq73vx

[ ] When an application is approved, remove the disabled Approved, Request Revisions, Reject buttons and replace with these buttons:
[ ] Disable the Remove Approved Pdf button
[ ] The download will be the signed pdf - the package that is submitted (already implemented)

Hook up the pdf upload

[ ] similar to the sign and submit file upload, clicking the Upload Approved PDF button will open a file browser that will allow for pdf upload only (Max file size: 5MB)

When an approved pdf is uploaded/found

zeplin: https://zpl.io/2v8w3oJ

[ ] Change the pdf label from "SIGNED PDF" TO "APPROVED PDF"
[ ] When clicked, this should download the zip package including signed pdf, approved pdf and any ethics letters that were uploaded to the application.
[ ] Enable the Remove approved pdf button
[ ] When admin clicks Remove approved pdf, the header button goes back to downloading the “Signed pdf” zipped package (and the label changes back to "Signed PDF")

kcullion commented 3 years ago

@ciaranschutte just a couple things:

[ ] for both the upload and remove buttons, when they are in loading state, the labels shift to two lines which causes a weird UI jump. Can you make it so the button labels are always on one line?

As mentioned on slack

[x] Bug: https://watch.screencastify.com/v/OKGtPD28kYi8Y02bZvl1 I upload a pdf…the remove button becomes enabled as expected. When I remove that approved pdf - it removes it as expected and disables the remove button. I try to upload a different approved pdf but nothing happens, I have to refresh the browser in order to make that second upload work.
[x] Another bug: https://watch.screencastify.com/v/QE73AVEgYdJVaNJa2kTF I upload a pdf. then when I click to upload a different pdf, but then cancel that, I see the "Please upload a pdf" error. But I already had a pdf uploaded? Cancelling the file upload shouldn't show the error when there is an approved letter uploaded.
[x] https://watch.screencastify.com/v/AkGRuM1SOUgj3DbC12OD When I go to an approved application and upload an approved pdf, the button label successfully changes to "Approved PDF". When I close that approved application, can you keep the label as "Approved PDF"? currently it goes back to "Signed pdf"

kcullion commented 3 years ago

Tested these bugs in QA and it all looks good now! Thanks @ciaranschutte !

kcullion commented 2 years ago

these buttons are working in staging

icgc-argo / dac-ui