[Data Hookup+UI] Admin Approval flow + Application state

kcullion commented 3 years ago

Goal

To complete the admin approval flow and transition the application to the correct state.

Note, the approval email that gets triggered will be built in the email epic here: https://github.com/icgc-argo/dac-ui/issues/68 (All emails to be built and triggered in this epic: https://github.com/icgc-argo/dac-ui/issues/65)

[x] build the UI for the approval confirmation modal: When DACO Admin clicks the "Approve" button from https://github.com/icgc-argo/dac-ui/issues/55, they see this modal: https://zpl.io/VkMmDJG that loads in: a. Application number and institution in brackets b. Access start date (reporting the current day - i.e. the day this button is clicked) c. Access end date (reporting one year after the start date)

[x] 1. When confirm approval, the application transitions into the APPROVED state
[x] 2. Most sections are locked for editing as shown here for section A: https://zpl.io/aBvEw80
[x] 3. For locked sections, all form fields are disabled and uneditable as seen here for section A: https://zpl.io/aBvEw80
[x] 4. Section C is unlocked in order to be able to add/remove collaborators

[x] 6. Section C table: remove the edit icons from each collaborator table row, the applicant cannot edit already existing collaborator information. But they can still add and remove collaborators. Zeplin: https://zpl.io/2jq8pqp

samrichca commented 3 years ago

Some work can't be completed right now because the following aren't implemented

Things I can't do yet:

Section E is locked if the applicant had chosen option 1 (do not require an ethics letter) and unlocked if the applicant had chosen option 2, that they require a letter.
If the applicant had chosen option 2 (required an ethics letter), show the ethics uploads that were originally submitted but hide the delete (trashcan) icons for those, as seen: https://zpl.io/beP4zMY
Disable option 1 (they cannot go from requires a letter to doesn't require a letter), as seen: https://zpl.io/beP4zMY
If the applicant uploads a new ethics pdf, that pdf is shown in the table and is removable, as seen: https://zpl.io/blOm11X

kcullion commented 3 years ago

Thanks @samrichca I'll move these items to a new ticket

kcullion commented 3 years ago

samrichca commented 3 years ago

@kcullion even better! thanks for finding that

kcullion commented 3 years ago

@samrichca yes I"m glad you didn't waste time on that! forgot that I put that as part of your ticket

rosibaj commented 3 years ago

Tested Jul 12, 2021

lgtm thank you @samrichca!!