[Data Hookup] Request Revisions flow + Application state

kcullion commented 3 years ago

Goal

To complete the request revisions flow and transition the application to the correct state.

Note, the request revisions email that gets triggered will be built in the email epic: https://github.com/icgc-argo/dac-ui/issues/65)

Endpoint to use

https://github.com/icgc-argo/dac-api/issues/17

Expected Outcomes

Confirmation Modal

This was built here: https://github.com/icgc-argo/dac-ui/issues/63

Connect this button:

if you get a failure, do a retry (visual change from @kcullion !)
[x] 1. When DACO admin confirms to send the request, the application transitions into the REVISIONS REQUESTED state Needs endpoint above to be connected to DACO admin button
Application state after requested revisions
[x] 2. All sections, that do not require revisions, are locked for editing as shown here for section A: https://zpl.io/Vqzx6DZ
[x] 3. For locked sections, all form fields are disabled and uneditable.
[x] 4. Unlock the sections that were specified in the request revisions modal, and show an orange pencil edit icon in the table of contents: https://github.com/icgc-argo/dac-ui/issues/63

Application state after revisions were requested for DACO Admin

[x] Once DACO Admin sends revisions request, remove the Approve/Request Revisions/Decline buttons from the orange admin bar.
[x] The application will be in the same state as it is above for the applicant ** Note the custom expiry should not be here - was left in mocks to do late orange bar should just be blank for now in this state.

kcullion commented 3 years ago

This seems to work well @samrichca ! Just noticed a couple things and ran them past @blabadi .... made a backend ticket for it https://github.com/icgc-argo/dac-api/issues/109

kcullion commented 3 years ago

@samrichca will that backend ticket affect you at all icgc-argo/dac-api#109? If not, this looks good and I'll move to awaiting release.

samrichca commented 3 years ago

that looks like we're not getting the right info from the backend. if we start getting the right info then the icons & access should display as expected

this ticket should be OK but we should test it when he's done, so leave it here as a reminder?

kcullion commented 3 years ago

thanks @samrichca I will move this to awaiting release and I added a testing note to the backend ticket to test the UI.

icgc-argo / dac-ui