search

icgc-argo / dac-ui

Development of the ICGC ARGO Data Access Control UI
https://daco.icgc-argo.org/
GNU Affero General Public License v3.0
0 stars 0 forks source link

✨ 504 - Add expiring status, renew button to dashboard card #646

Closed anncatton closed 1 year ago

anncatton commented 1 year ago

Dashboard status text, date and renew button for approved applications within the renewal period (before expiry). Refactors some of the conditionals for status display. Allows a custom Button component Adds calc function for renewal period end date (expiry + 90 days) - currently this is hardcoded, either switch to a configurable value, or get this value from the BE in some form (a new field or retrieve config from api)

justincorrigible commented 1 year ago

Quick question: what's the difference between appId and renewalAppId? is the latter an id for a different type of app than the "regular" one?

anncatton commented 1 year ago

Quick question: what's the difference between appId and renewalAppId? is the latter an id for a different type of app than the "regular" one?

the renewalAppId is the id of the renewal application that is copied from this original app. we track a link between the original and the renewal app, so the renewal application will also have a sourceAppId to link back to the original

justincorrigible commented 1 year ago

Oh so there is in fact something called a "Renewal app"? awesome. Thanks for clarifying! DACO has reaaally changed since I was involved.

anncatton commented 1 year ago

haha yeah @caravinci renewals were in the initial roadmap but this implementation is much different than what we had planned 🙂