search

icgc-argo / platform-api

https://api.platform.icgc-argo.org/graphql
GNU Affero General Public License v3.0
0 stars 0 forks source link

🐛 Zip files are "corrupted" on Mac #360

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

Describe the bug

Zip Files opened in Mac by the Unarchiver say the zip files are corrupted:

image image

Steps To Reproduce

Steps to reproduce the behaviour:

  1. From a Mac machine, go to https://api.platform.icgc-argo.org/api-docs/#/Clinical%20Proxies/get_clinical_template_all and download the template, or download the templates from https://docs.icgc-argo.org/dictionary
  2. Try to open the downloaded zip file. you will be told the file is corrupted.

Related Helpdesk ticket

https://extsd.oicr.on.ca/browse/ARGOHD-137

Make sure this is answered when resolved.

Possible Solution

from @andricDu

I'm not sure how the templates are being created, but It looks like they are not new line terminated. without the newline, w/e is reading the files will think the line doens't end. like its dangling and got truncated during transmission

from @samrichca

i tried creating a new zip with the terminal-unzipped files, and then unzipping it by clicking, which worked. hopefully adding the newline helps

Expected behaviour

The files should unzip on all systems.

rosibaj commented 3 years ago

Tested with Kim on Mac; the highlighted issues have been resolved. Mac users can now unzip the files.

rosibaj commented 3 years ago

@samrichca I need a software version number on this before i can move this ticket forward! Can you please add the label?

rosibaj commented 3 years ago

Tested by Kim on Feb 18, 2021 on Mac - confirmed to unzip correctly.