update Gateway-API schema with Mutect2 fields for donor-dashboard

icgc-argo / platform-api

https://api.platform.icgc-argo.org/graphql

GNU Affero General Public License v3.0

0 stars 0 forks source link

update Gateway-API schema with Mutect2 fields for donor-dashboard #368

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

should mimic the area that already there for sanger/alignment etc
extension of same functionality.

Expected Outcome

From platform api, I should be able to query the donor_dashboard section and see the three new mutect2 fields (should have no data)

rosibaj commented 3 years ago

@Buwujiu Looks great for the most part - I did have an error when querying one specific program TEST-PR:

query {
  programDonorSummaryEntries(programShortName:"TEST-PR"){
    sangerVcsFailed
    sangerVcsRunning
    mutectFailed
    mutectRunning
    mutectCompleted
  }
}

Error:

 "message": "Cannot return null for non-nullable field DonorSummaryEntry.sangerVcsFailed.",

rosibaj commented 3 years ago

After discussion, moved feedback above to a new ticket: https://github.com/icgc-argo/platform-api/issues/373

rosibaj commented 3 years ago

tested on QA with UI - data deliver is happening to the table now as expected, so that means the gateway api is working as expected. LGTM!

Thank you very much @Buwujiu !

rosibaj commented 3 years ago

confirmed on prod release - the gateway does have the fields. some errors appear to be happening on sort, but i don't think related to this.