search

icgc-argo / platform-api

https://api.platform.icgc-argo.org/graphql
GNU Affero General Public License v3.0
0 stars 0 forks source link

🐛 Storage-api entities isn't filtering on gnosId #457

Closed jaserud closed 3 years ago

jaserud commented 3 years ago

Describe the bug

score client will look for objects/entities via gnosId from gateway metadaurl (because thats how the endpoint is setup in song) but gateway isn't filtering on gnosId correctly.

Steps To Reproduce

  1. request for entities from storage-api using gnosId (analysisId) and projectCode (studyId) in swaggerui GET /storage-api/entitie
  2. look at response which hasn't filtered by gnosId image
  3. Scratch your head and wonder why...

Expected behaviour

Should be looking for gnosId in query not anlaysisId: https://github.com/icgc-argo/platform-api/blob/4a95ba6b734a5dc68d779b8dbeda99f9467cdd1b/src/routes/file-storage-api/handlers/entitiesHandler.ts#L115

joneubank commented 3 years ago

Looks like gnosId is just a label given to the analysis.analysis_id and can be filtered using the query name analysisId.

So the functionality is there, but the open question is: rename the query param or rename the value in the output.