icgc-argo / platform-api

https://api.platform.icgc-argo.org/graphql
GNU Affero General Public License v3.0
0 stars 0 forks source link

🐛 Cannot download publicly released open file with no access token provided #487

Closed rosibaj closed 2 years ago

rosibaj commented 3 years ago

image

kcullion commented 3 years ago

@joneubank for testing this one on QA should I be able to go to open files in the file repo and be able to download them using the "file" download button in the top right? If so, nothing is downloading for me.

joneubank commented 3 years ago

file download button is not implemented.

the testing needed for open access files is that you can download them without DACO scope. So for a RESTRICTED + open file you need to be logged in and able to see the files for that program (scope of PROGRAM_PRGM-AA.READ and PROGRAMDATA_PRGM-AA.READ) . For PUBLIC and open you can download without even being logged in (all users and anonymous can download).

All downloads for this need to be done through the score client until that file download button is built.

kcullion commented 3 years ago

Ok thanks @joneubank now I realize this was an API ticket. I saw the screenshot of the interface and thought it was in the UI.

But I did make a ticket to implement that button, so I mentioned this ticket on that: https://github.com/icgc-argo/platform-ui/issues/2091