icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit
http://platform.icgc-argo.org/
GNU Affero General Public License v3.0
7 stars 7 forks source link

Add "Access" facet when logged in #1764

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

facet on left

Full member Zeplin (shows tooltip open - which would show on hover of the ?): https://zpl.io/2jDelJx They can filter on all stages to see what files they have access for each

Screen Shot 2020-10-22 at 12 09 24 PM

Associate member Zeplin: https://zpl.io/br4jk83 They can filter on all stages except the files in the Full membership stage

Screen Shot 2020-10-22 at 12 06 41 PM

Selected and Hover state for new facet: Zeplin: https://zpl.io/25LMg4J

2020-10-22_12-15-15

** NOTE: do not reorder the values on this facet only.

ciaranschutte commented 3 years ago

@ciaranschutte will need to integrate with https://github.com/icgc-argo/platform-api/issues/294

rosibaj commented 3 years ago

@ciaranschutte linked tickets!

ciaranschutte commented 3 years ago

@rosibaj need to do more work with @hlminh2000 to resolve local build issue with platform-api

hlminh2000 commented 3 years ago

@ciaranschutte if you are able to get the tests to pass locally, I think we can turn off the unstable tests for now to move things forward, and revisit test stability later

ciaranschutte commented 3 years ago

@rosibaj not working in dev yet. I updated the feature flag yesterday. Looking into this now.

rosibaj commented 3 years ago

perfec thank you @ciaranschutte !

ciaranschutte commented 3 years ago

@rosibaj in QA. there seems to be an extra row in the Access Facet with no title. Also #files isn't matching with table.

ciaranschutte commented 3 years ago

rosi

rosibaj commented 3 years ago

@ciaranschutte can you please add a version to this ticket to indicate what version this change represents?

rosibaj commented 3 years ago

@ciaranschutte This all looks great for now! I have some feedback on data/behavior testing, but the UI portions of this are well covered! thank you! As soon as we get a software version on this we can move to awaiting release!