🐛 RDPC Redirect is wrong

icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit

http://platform.icgc-argo.org/

GNU Affero General Public License v3.0

7 stars 7 forks source link

🐛 RDPC Redirect is wrong #1789

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

Make sure you are not dcc admin
make sure you are an RDPC user

Click the program Services button on the plaform. If logged in, you will be redirected to /rdpc or /rdpc will be added to the redirect after login. this leads to a DNE page.

https://github.com/icgc-argo/platform-ui/blob/e435ee3aa3b4a68f56dec05e9d5c41250a1c9352/global/utils/pages/index.tsx#L44

Solution

Remove the RDPC page as it will ne be used currently or the near future
check the code for /rdpc references.

ciaranschutte commented 3 years ago

@rosibaj DNE page.? do not enter?

rosibaj commented 3 years ago

@ciaranschutte Does Not Exist.... its a maths term that i probably should not have assumed everyone knows :)

ciaranschutte commented 3 years ago

@ciaranschutte looks good in dev

rosibaj commented 3 years ago

@ciaranschutte can you please add a version to this ticket to indicate what version this change represents?

rosibaj commented 3 years ago

Tested on QA environment -

when i had access to a program as a data submitter, successfully landed on a program dashboard
when i had no access to a program, successfully landed on user page.
Thanks for the fix @ciaranschutte !!