icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit
http://platform.icgc-argo.org/
GNU Affero General Public License v3.0
7 stars 7 forks source link

Add File Entity Page to Platform. #1855

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago
ciaranschutte commented 3 years ago

is this still part of the File Repository? If so it should have a similar url to the submission eg. repository/program/file also File Repository in the navbar should remain in selected state

rosibaj commented 3 years ago

@ciaranschutte no its not part of the file repository. Donrs/Programs/Files should be their own entity, like so:

https://platform.icgc-argo.org/file/FI12533 would be the URL path to resolve.

ciaranschutte commented 3 years ago

@ciaranschutte

FileID

file {
    hits(filters: $filters) {
      total
      edges {
        node {
          analysis {
            experiment {
              experimental_strategy
              platform
            }

            workflow {
              workflow_name
              workflow_version

            }
            analysis_type
            analysis_version
            variant_class
          }

data analysis [data type, genome build, software, workflowType: get(entity, 'analysis.workflow') ]

rosibaj commented 3 years ago

@ciaranschutte i said fileID, but we don't have that yet so you can use objectID

rosibaj commented 3 years ago

@ciaranschutte any chance to getting this to QA today?

ciaranschutte commented 3 years ago

Which users can see the page? Which users can download a file?

ciaranschutte commented 3 years ago

needs dev / qa env update

rosibaj commented 3 years ago

@ciaranschutte looks good a couple things:

ciaranschutte commented 3 years ago

@rosibaj @joneubank Do we have program_shortcode available from gateway? I only see short code in the queries.

I believe it should be added to the file query as it only has the shortname displayed here already and needs to remain an unauthenticated endpoint for file repo.

joneubank commented 3 years ago

right now we only have this in the program service, it is not available to query by the UI. We should put some thought into how we want to make this kind of program specific info available in more places.

rosibaj commented 3 years ago

ok @ciaranschutte you can just leave it showing the study-id/shortcode as it is showing now for that feeedback then.