icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit
http://platform.icgc-argo.org/
GNU Affero General Public License v3.0
7 stars 7 forks source link

Donor entity: Available Files card #1863

Open rosibaj opened 3 years ago

rosibaj commented 3 years ago

Goal

To build the available files card that will provide easy access to different types of files for this donor.

Data source: a new donor centric index

Blocked until we have a donor centric index.

Zeplin: https://zpl.io/2937nPY

Expected outcomes

image

akachru-github commented 2 years ago

Clinical API should be updated with the logic to provide a value like "NA". Business logic should not be added to the FE to interpret a return like "NULL" for example. @joneubank , @mistryrn , @demariadaniel to connect on this to agree how this will work.

akachru-github commented 2 years ago

As first step:

Buwujiu commented 1 year ago

Question for @edsu7 @lindaxiang : The mockup shows less Data Category than what's on argo qa right now: Screen Shot 2022-11-11 at 1.06.32 PM.png Do we want to have all the data categories on the file cards?

lindaxiang commented 1 year ago

@Buwujiu , Data Categories in QA are a bit messy. In Prod, we should not have that many categories, maybe we can make the info on file cards to be consistent with facet in the file repository.

Buwujiu commented 1 year ago

@Buwujiu , Data Categories in QA are a bit messy. In Prod, we should not have that many categories, maybe we can make the info on file cards to be consistent with facet in the file repository.

@lindaxiang do you mean we should have a fixed list of Data Category on the available file cards? would this. be easier for users?

lindaxiang commented 1 year ago

@Buwujiu no, I meant the dynamic list of Data Categories are preferable. But if it is hard to implement, we can use a fixed list. And we will need to update it whenever new Category is added.

Buwujiu commented 1 year ago

@Buwujiu no, I meant the dynamic list of Data Categories are preferable.

@lindaxiang is it possible that a donor might not have files in data categories? Say we have 8 categories in total, but some donors might only have files in 5 of those categories?