search

icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit
http://platform.icgc-argo.org/
GNU Affero General Public License v3.0
7 stars 7 forks source link

🐛 Update Message for Invalid Donors #1878

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

Currently the message when you have invalid donors is this: image

This message needs to be updated to be more accurate now that we have changed our Release rules; >

Title: 10 donors are invalid and will be revoked if not corrected. Body: [Version 81.8]() of the data dictionary was released and has made some donors invalid against the latest dictionary. Please correct the clinical data for the highlighted donors.

Message is here: https://github.com/icgc-argo/platform-ui/blob/45f37da687bc77bd21f9a29fea81abca6049621b/components/pages/submission-system/program-dashboard/DonorDataSummary/InvalidDonorsNotification.tsx#L45

ciaranschutte commented 3 years ago

@rosibaj Is there a quick way to recreate this error? I've tried uploading invalid donor.tsv in clinical but I'm getting the validation errors instead

rosibaj commented 3 years ago

@ciaranschutte it happens when you migrate a dictoinary - not easy to recreate. its currently visible here https://platform-ui.qa.argo.cancercollaboratory.org/submission/program/DASH-CA/dashboard

ciaranschutte commented 3 years ago

thank you. Seen as this is a straightforward text change I'm going to move this to QA to check rather than spend time recreating in dev.

rosibaj commented 3 years ago

@ciaranschutte sounds good to me!

rosibaj commented 3 years ago

message confirmed on DASH-CA: image

lgtm thank you @ciaranschutte !

rosibaj commented 3 years ago