icgc-argo / platform-ui

Home of Argo Platform UI + @icgc-argo/uikit
http://platform.icgc-argo.org/
GNU Affero General Public License v3.0
7 stars 7 forks source link

bug/#2681-program-entity-summary-section-with-multiple-values-missing-delimiter(comma) #2745

Closed daniel-cy-lu closed 10 months ago

daniel-cy-lu commented 10 months ago

Issue: Program Entity table rows with multiple values are missing spaces and comma between these values. These rows are regions, countries, institutions, primarySites and cancerTypes

Solution: format the query with array.join() method. The results are values with space and commas in between.

Was able to test countries, primarySites in dev. Couldn't edit programs to test the other three rows. But since the update works on countries and primarySites, it should work for the rest as well.

Screenshot Showing space and comma between values in primarySites and countries. Screenshot 2023-11-30 at 4 20 09 PM

Type of Change

Checklist before requesting review

daniel-cy-lu commented 10 months ago

@demariadaniel Thank you Dan like always!