icgc-argo / roadmap

Place to review/request new features and new tools on ICGC-ARGO's roadmap
1 stars 0 forks source link

2. Allow data upload with exception on number field #1083

Closed bhavikbhagat93 closed 4 months ago

bhavikbhagat93 commented 6 months ago

Description

When number exception is set on number field, user should be allowed to

  1. Upload data with blank values on exception fields.
  2. Validate data with blank values on exception fields.
  3. Approve data with blank values on exception fields.

Acceptance criteria

For MUTO - INTL, user should be able to perform above action with exception on following fields

specimen_acquisition_interval treatment_start_interval treatment_duration

demariadaniel commented 5 months ago

Test case # 1 Successful exception submitted for field treatment_start_interval Record successfully passes schema validation and clinical validation with field empty

Test records: (Zenhub does not allow TSV uploads) treatment_test_exception1.txt

Exception record: exception_test1.txt

Screenshot 2024-01-19 at 3.40.44 PM.png Screenshot 2024-01-23 at 11.28.55 AM.png
demariadaniel commented 5 months ago

Test Case 2

Successful exception submitted for field treatment_duration Record successfully passes schema validation and clinical validation with field empty

exception_test2.txt

treatment_test_exception2.txt

Screenshot 2024-01-19 at 3.51.42 PM.png Screenshot 2024-01-23 at 11.38.06 AM.png
demariadaniel commented 5 months ago

Test Case 3

Successful exception submitted for field specimen_acquisition_interval Record successfully passes schema validation and clinical validation with field empty

exception_test3.txt

specimen_test_exception1.txt

Screenshot 2024-01-19 at 4.13.21 PM.png Screenshot 2024-01-23 at 11.46.26 AM.png
demariadaniel commented 5 months ago

Updated Specimen exception for testing entity exceptions

exception_entity_test3.txt

demariadaniel commented 5 months ago

PR: https://github.com/icgc-argo/argo-clinical/pull/1108