icgc-argo / song-search

Song Search - GQL microservice for searching maestro generated song indexes
GNU General Public License v3.0
0 stars 0 forks source link

Get Matched Tumour/Normal Pairs by Donor ID #67

Closed joneubank closed 2 years ago

joneubank commented 2 years ago

Add a query that takes donorId as input and returns an array of matched tumour/normal pairs for that Donor.

jaserud commented 2 years ago

Unexpected behavior observed with this query in qa:

query { sampleMatchedAnalysesForDonor(
  req: {
    donorId: "DO262418",
    analysisType: "sequencing_experiment"
  }
) {
    normalSampleAnalysis{
      analysisId
      studyId
      analysisType
      analysisState
      donors {
        donorId
        submitterDonorId
      }
    }
    tumourSampleAnalysis{
      studyId
      analysisId
      analysisType
      analysisState
      donors {
        donorId
        submitterDonorId
      }
    }
  }
}

Query matched samples across studies and with different donorIds: image

There is bad data here, but the query should filter the pairs to match the sampleId and donorIds. Also add optional studyId to filter pairs matched across studies.

jaserud commented 2 years ago

Add sampleType to request and add constraint to check sampleTypes are equal for matching samples. https://github.com/icgc-argo/song-search/pull/75

jaserud commented 2 years ago

some legacy analyses use library_strategy instead of experimental_strategy. Need to check the values match for both of these fields.

b-f-chan commented 2 years ago

Released to prod, closing