icgc-dcc / dcc-portal

Data portal for exploring and accessing data
https://dcc.icgc.org/
Other
15 stars 8 forks source link

Genome Viewer Is Broken #702

Closed andricDu closed 7 months ago

andricDu commented 3 years ago

Gene page link: https://dcc.icgc.org/genes/ENSG00000157764/genome-viewer Generic link to viewer: https://dcc.icgc.org/browser

Examples of constant loading: image image

Update: Backlog grooming discussion March 9th While it is sad, it is time to retire this feature.

justincorrigible commented 3 years ago

This is likely the cause of the problem: image Seems the endpoint for this has gone missing, without sufficient error handling.

justincorrigible commented 3 years ago

Removed from (for testing purposes):


Footer (1 occurrence)

Screenshot 2021-03-11 at 21.46.58.png


Oncogrid (1 occurrence)

Screenshot 2021-03-11 at 22.17.19.png


Gene view (1 occurrence)

Screenshot 2021-03-11 at 22.06.34.png


Compound view (1 occurrence)

Screenshot 2021-03-11 at 21.58.45.png


Mutation view (2 occurrences)

Screenshot 2021-03-11 at 22.21.18.png


Advanced search (3 occurrences)

Screenshot 2021-03-11 at 21.41.12.png

Screenshot 2021-03-11 at 21.50.57.png

Screenshot 2021-03-11 at 21.53.41.png


Browser

image.png

rosibaj commented 3 years ago

@caravinci is this testable somewhere?

justincorrigible commented 3 years ago

Indeed, you should be able to see it in the staging server Dusan set up for us.

rosibaj commented 3 years ago

March 24, 2021 Tested All changes tested; most look good with the exception of one issue found: Gene page is not loading correctly: image

justincorrigible commented 3 years ago

Seems I had removed only the template references, but didn't really remove the controller logic completely. etc.

Please feel free to test it again, @rosibaj

rosibaj commented 3 years ago

Tested April 01, 2021 2:30

No additional testing feedback. Thank you for the changes @caravinci . Moving to Awaiting release. Maybe we can bundle this witht he short url, or if we can deploy just this then let me know!

justincorrigible commented 3 years ago

We can deploy all this any time, as nothing related to ShortURLs will break any more than it is. I'll queue it up next week, if that sounds good to you.

justincorrigible commented 7 months ago

Closing as done