Update the Share Button: Sharing query by short URL is broken

[christinayung]

• [ ] Update share feature on Repositories Page

Loading icon keeps spinning

• [ ] Update share feature on Advances Search

When the "Share" button above the table is clicked, usually a shortened link appears, but it's stuck on "Loading":

• [ ] Update share from Project List Page

• [ ] Update from all Analysis type pages:

[junjun-zhang]

found a couple of places with specs/implementations of url shortening service:

• https://jira.oicr.on.ca/browse/DCC-2405
• https://wiki.oicr.on.ca/display/DCCSOFT/Short+Url+Component
• https://github.com/icgc-dcc/dcc-common/blob/develop/dcc-common-client/src/main/java/org/icgc/dcc/common/client/impl/shorturl/DefaultShortURLClient.java#L39-L40, there is a configuration for the actual short url service config.getShortServiceUrl() which was implemented by the web dev team
• https://wiki.oicr.on.ca/display/icgcweb/Shorten wiki page from web dev team

[rosibaj]

QA summary in https://github.com/icgc-dcc/dcc-portal/issues/708

was able to generate short urls from all pages.

[rosibaj]

@caravinci are you still waiting on a code review here?

[justincorrigible]

@rosibaj 'fraid so: https://github.com/icgc-dcc/dcc-portal/pull/723 noticed there was a bug in the portal, creating new urls, because of a bug in the old url shortener itself.

this takes care of that.

[justincorrigible]

Closing as "not needed" before decomissioning