search

ich777 / docker-steamcmd-server

Simple Dockerfile that installs steamcmd and a selected game server
119 stars 95 forks source link

Added support for Carbon Mod #45

Closed ShawnTheShadow closed 8 months ago

ich777 commented 8 months ago

Thank you for the PR.

I can't accept that PR with your docker-publish.yml and docker-image.yml

I'm also missing something like that in start-server.sh right at line 52:

if [ "${OXIDE_MOD}" == "true" ] && [ "${CARBON_MOD}" == "true" ]; then
  echo "Oxide and Carbon mod enabled, you can only enable one at a time, putting container into sleep mode."
  sleep infinity
fi

And I would rather recommend that you put line 148 in the newly added if condition for Carbon mod maybe here.

ich777 commented 8 months ago

Container is already built with your changes. Thank you!

ShawnTheShadow commented 8 months ago

There's probably a better way to show and compare version numbers, but carbon uses "production" as the tag, I'm not so good with regex to do a proper compare with the number in the name.

ich777 commented 8 months ago

@ShawnTheShadow I just take a quick look into that and that's really stupid what they are doing there since the tag should be the version number, maybe try to create an issue over there in their GitHub since Tags should always be a version number or something unique.

Sure the routine can be changed so that the version number is extracted but I would rather recommend that the fix that on their end...