Closed ShawnTheShadow closed 8 months ago
Container is already built with your changes. Thank you!
There's probably a better way to show and compare version numbers, but carbon uses "production" as the tag, I'm not so good with regex to do a proper compare with the number in the name.
@ShawnTheShadow I just take a quick look into that and that's really stupid what they are doing there since the tag should be the version number, maybe try to create an issue over there in their GitHub since Tags should always be a version number or something unique.
Sure the routine can be changed so that the version number is extracted but I would rather recommend that the fix that on their end...
Thank you for the PR.
I can't accept that PR with your
docker-publish.yml
anddocker-image.yml
I'm also missing something like that in
start-server.sh
right at line 52:And I would rather recommend that you put line 148 in the newly added if condition for Carbon mod maybe here.