search

ichiban / prolog

The only reasonable scripting engine for Go.
MIT License
564 stars 27 forks source link

Expose all error constructors #313

Closed ccamel closed 6 months ago

ccamel commented 7 months ago

This PR tackles issue #310.

I propose to make all error types public, similar to how domain_error and others were previously made accessible. Given our project's significant reliance on ichiban/prolog, having access to the entire spectrum of error types used by the library would be highly beneficial for us as developers.

This means making these error constructors available for everyone: existence_error, permission_error, representation_error, resource_error, syntax_error, and evaluation_error.

Thanks.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c682cd3) 99.21% compared to head (11c4f43) 99.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #313 +/- ## ======================================= Coverage 99.21% 99.21% ======================================= Files 23 23 Lines 7272 7283 +11 ======================================= + Hits 7215 7226 +11 Misses 51 51 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ccamel commented 6 months ago

@ichiban Thanks for the code review and your insightful comments. Much appreciated. I've made the updates.