Ignore undefined fields of schema onCreate

[ArkeologeN]

Currently, if you pass any field that is not part of your declare or model, it would still allow you to set one. e.g:

var TUser = db.declare('TUser', {
    autoincrement: false,
    properties: {
      fUserFirstName: 'string',
      fUserLastName: 'string',
      fUserFullName: 'string',
      fUserPassword: 'string',
....

When you directly refer any object (in my case req.body), it will set those fields over object and it looks like this:

{ _id: false,
  fUserFirstName: 'hamza',
  fUserLastName: 'waqas',
  fUserEmail: 'hamza@hamza.com',
  username: 'admin',
  fUserPassword: 'admin' }
// `username` must have not been there in this object.

It was reproduced using this:

var user = TUser.create(req.body);
  console.log(user);

Thanks!

[ichiriac]

I'm agree with you, objects should serialize only their own parameters for storage.2 ways to do that :

1 - as Javascript is permissive you could construct or assign to an object a property that should not be stored in couchbase.

2 - from construct or when an undefinded property is set it should trigger an error

• The 1st solution enables you to work with objects temporary properties easily
• The 2nd solution avoid typo errors hell to debug

You see other ways to do this ?

[ArkeologeN]

I think going with 1st solution is fine. However, we could interpolate properties from schema when firing a save event or action. Initially:

• If someone pass the POJO directly to the constructor, we call internal method to remove undefined fields from schema.
• If someone uses setter to define a property, we could either ignore it for a while or bind a event emitter to raise error immediately. If we ignore it for a while, we can validate the entire object with schema onSave.

What do you think?

[ichiriac]

If we go with the first solution, I could be permissive on construct & setters, and at onSave pass to couchbase an new intermediate POJO mapped with only defined properties.