Closed nephros closed 1 year ago
Thank you! I'll review and release it asap :).
Thank you! I'll review and release it asap :).
Sure thing.
One thing I noticed is that it does have an issue with the "Improved stock emoji keyboard" patch, as that patches Settings icon now floats way above the VKB.
But the configuration interface for that patch has been wonky for me since forever anyway, not sure why.
One thing I noticed is that it does have an issue with the "Improved stock emoji keyboard" patch, as that patches Settings icon now floats way above the VKB.
The emoji keyboard settings interface is actually "below" the keyboard and becomes visible by changing the keyboard size. This explains why there might be conflicts between the two patches. It doesn't explain however why the Settings button gets messed up.
I'd also like to find a way to make the patch compatible with SFOS 3 and 4, so I'll merge not yet.
As I finally updated my phone to SFOS 4.5, I merged this manually in v1.0.2 but also replaced the whole patch by a new one that combines my three keyboard size patches. (Hoping that this makes it easier to maintain - less patches, less work...)
One thing I noticed is that it does have an issue with the "Improved stock emoji keyboard" patch, as that patches Settings icon now floats way above the VKB. But the configuration interface for that patch has been wonky for me since forever anyway, not sure why.
I couldn't reproduce this and I don't quite know where to start debugging it, as the settings key is just a normal FunctionKey
just like backspace, shift, etc. Does it still happen on your end?
I'd also like to find a way to make the patch compatible with SFOS 3 and 4, so I'll merge not yet.
Didn't do that, it's too much of a hassle...
Edit: I'll close this PR but let's discuss the emoji issue in the SFOS forum thread.
make the patch compatible with SailfishOS 4.2 tie offset to screen height not keyboard height
Note: 1.0.1 does work as intended with SFOS 4.0 and 4.1 but I don't have the jolla-keyboard version available to set the dependency.