search

ichttt / FirstAid

A Minecraft Mod that changes the vanilla health system
GNU General Public License v3.0
32 stars 31 forks source link

First Aid 1.20.1 Incompatible with PlayerRevive #230

Open DogeKingChris opened 8 months ago

DogeKingChris commented 8 months ago

It breaks the game in many ways. The death timer resets when getting hit/taking damage from any source. you can be at 0 hp in all body parts yet still live. if you die from the timer while at 0 hp in all body parts, the game crashes on respawn and only way to fix is to delete player data. if you have regeneration and heal to max hp while downed, then die, your game crashes on respawn and only way to fix is to delete player data.

DogeKingChris commented 4 months ago

I hope this gets fixed on 1.20.1 😅

ichttt commented 4 months ago

Sorry, but I can't reproduce most of the issues. I could reproduce the issue of the timer resetting, and this will be fixed in the next release, but I just can't reproduce the other issues. I am going to release a new version for 1.20.1 soon. Can you try and reproduce the bug? If so, can you send me log files from both the server and client?

DogeKingChris commented 4 months ago

I can't get player revive to work at all on this new update. It's almost like the mod is disabled. I think since they have in their description that first aid is incompatible, they might have in their code something that disables PlayerRevive when first aid is installed. I dont know

DogeKingChris commented 4 months ago

OH, player revive disables in singleplayer. I activated it now, and first aid works perfect so far!

DogeKingChris commented 3 months ago

Ok, I found another problem. If you go down, you don't have any hp, so when you revive, you just die.

DogeKingChris commented 3 months ago

I fixed it by increasing the hp it gives you on revive, but it heals a random body part so its a hit or miss

Buttersxx commented 1 month ago

I fixed it by increasing the hp it gives you on revive, but it heals a random body part so its a hit or miss

Can you explain to me what lines you adjust? so i can get it to work im on forge 1.20.1