icicle-lang / icicle-ambiata

A streaming query language.

BSD 3-Clause "New" or "Revised" License

57 stars 11 forks source link

Generate Ord type based on original type. Generate map primitives with Ord #633

Closed amosr closed 6 years ago

amosr commented 6 years ago

Don't generate Map primitives with arrays as the keys.

625

! @jystic @tranma /jury approved @jystic

tranma commented 6 years ago

Doubles are not 'Ord' because NaN

YOUR MATHEMATICS IS POWERLESS HERE

amosr commented 6 years ago

I had disabled generating PrimWindow because I saw a test failure involving it, but I've re-enabled it and ran several tests, as well as looking at the conversion, and it seems to be fine. The failure I saw was probably NaN or Ord and just happened to also contain PrimWindow.

jacobstanley commented 6 years ago

☝️ 👆