Do not encode url characters in response headers

icicleio / http

HTTP component for Icicle

MIT License

61 stars 5 forks source link

Do not encode url characters in response headers #17

Closed jvasseur closed 8 years ago

jvasseur commented 8 years ago

We need to allow "?" in response headers to allow redirecting to an url with a query string.

coveralls commented 8 years ago

Coverage remained the same at 61.346% when pulling 39f53424f13fc2eadd27a83b351656fcfc93d41c on jvasseur:fix-header-encoding into 0681d283612c519992b61d0a84d3b7d1444fe7c6 on icicleio:v0.3.x.

jvasseur commented 8 years ago

ping @trowski

trowski commented 8 years ago

Sorry, totally missed this here somehow. Looks great!

I wonder then if some other characters should be excluded, like # and @?

jvasseur commented 8 years ago

# should probably be allowed too. Not sure about @, can we redirect to an url with some user information ?

trowski commented 8 years ago

Not a common use-case I'm sure, but I don't see why not.

jvasseur commented 8 years ago

Updated to allow # and @.

coveralls commented 8 years ago

Coverage remained the same at 61.346% when pulling 72ee69b6cd76f4a114ee0a1870dff8aa553b7a5b on jvasseur:fix-header-encoding into 0681d283612c519992b61d0a84d3b7d1444fe7c6 on icicleio:v0.3.x.