Open Netherquark opened 3 years ago
Thanks for all the feedback! βΊοΈ I couldn't keep up anymore with the Twitter messages, so thanks for making a summary π
Few things:
[Question] Will Diffuse still work on Chrome once the third party cookie support is removed? Cause I've noticed that user layer login credentials are stored in cookies [not sure though]
I'm not using cookies in any way, so it should work just fine. What gave you the impression cookies are used? π€
Thanks for all the feedback! βΊοΈ
My pleasure!
Few things:
- The last.fm scrobble only comes through if the track is played for 50%, unless your track is only 2 min long, or something like that. This is required by last.fm
Ah okay
[Question] Will Diffuse still work on Chrome once the third party cookie support is removed? Cause I've noticed that user layer login credentials are stored in cookies [not sure though]
I'm not using cookies in any way, so it should work just fine. What gave you the impression cookies are used? π€
Clearing cookies & clearing storage is what I do usually if I want to reset diffuse (eg if I type in the wrong credentials). Also diffuse uses Google and dropbox cookies during login? It's always a good thing if diffuse doesn't need cookies tho
If I have a song file, say "Alien Ant Farm - Smooth Criminal.mp3", and I delete that file from the drive, and replace it with "Alien Ant Farm - Smooth Criminal.mp3", but at a higher bitrate, as a part of upgrading my library bitrate. What happens is, diffuse directs the old processed entry to this new file, while also processing the new file, resulting in duplicate entries. The only possible way to fix this is to export diffuse.json, edit it to remove all mentions of the duplicate file in question, import it into diffuse, and process the sources, where it just creates one valid entry.
That's quite a special use case π€ I can't really think of a great solution. But for now you can do one of the following:
The tags (audio metadata) are different but same filename, right?
After a certain point of time, Diffuse gives the "Can't play this track" error on every song that isn't cached till it is reopened. [Screenshot attached.] This happens even on a 250mb/s LAN connection, so it can't be related to internet issues. The same thing occurs on a very low-speed internet connection (1.5mbit/s)
Huh interesting, I guess there's a rate limit on Google Drive. I don't think there's much I can do about that, seeing that it's a limitation of Google Drive. I could show a message to the user however.
That's quite a special use case π€ I can't really think of a great solution. But for now, you can do one of the following:
- Delete the files on your source/drive, click process, wait until finished, upload new files, process again.
- Upload new files, alt + right-click on each changed track, and choose "sync tags"
The tags (audio metadata) are different but the same filename, right?
yep same file name different metadata (eg the higher-res version has album art, album metadata, genre, etc) i think the best solution to this would be to give the user a scan button, which would automatically look through for inconsistencies (eg multiple listings as per the Smooth Criminal example, tracks that show up as cached but aren't actually cached) because the best way I found of fixing the above issue on a per-song basis was to ctrl f the diffuse JSON with the song name, and remove all entries, so it was reprocessed.
I am creating a GitHub issue with all the bug reports & feature requests instead of sending them to @icidasset 's Twitter so it's more easily trackable and he won't need to check social media while working lol I'll edit this issue and add other things as I find them or think of them
Bold β‘οΈ Easy to solve
EDIT by @icidasset: π Will investigate β Done π₯Ά Not possible π« Not going to do
Feature requests:
Solved
L
key) Search functionality for playlistslive tile implementation in diffuse (documentation)Live tile has been discontinued in Windows 11Bugs:
Chrome
Chrome on Android 10/11
[ ] If I search for a song, and then long press it to add it to queue, say, the keyboard doesn't go away automatically and interferes. Maybe an auto keyboard lower API could be called or something? [Screen Record]
[ ] Diffuse lags while scrolling through the library on a midrange Android device
[ ] Diffuse doesn't scale to a display of less than 1600x1080p when using the split-screen feature in Android. The UI is scrollable if that is the case.
Chrome on Ubuntu 20.04/20.10/21.04
Firefox
Firefox on Windows 10/11
Firefox on Manjaro/Fedora
Firefox on Android 11
Miscellaneous (Universal/Chrome on Windows)
(#302)
Solved
306
GET https://www.googleapis.com/drive/v3/files/1x6MWDRyjBnkDmwwkSJQbSmgx_F8GxWln?alt=media Status 403 Forbidden
comment by icidasset: This is because Google Drive's API is rate limited. If you play music a lot this'll pop up once in a while. If you'd like to avoid this, consider switching to a different type of source, such as Amazon S3 or Azure, which are optimised for this.306
Failed to load βhttps://www.googleapis.com/drive/v3/files/1oN43m0Oo8GO_vIDi2VJSp9iYMhjPNd2i?alt=media&access_token=ya29.a0ARrdaM8eEVB_0RoiIaViXznvUt7Hgudh8tK6FV2nx1CQ2kDPqlzMOTAbne7tmkS2scOU1tWEZn-wB_ZdXy-KpfNDiUUOlmELNCr-1uWlza9_-z-3DZsF-ka0YLeuFxEtDZwLO9TUF19ECDMPszzJbvZH5wE_8wsβ. A ServiceWorker passed a promise to FetchEvent.respondWith() that rejected with βTypeError: NetworkError when attempting to fetch resource.β.