icing / mod_h2

HTTP/2 module for Apache httpd
https://icing.github.io/mod_h2/
Apache License 2.0
256 stars 41 forks source link

fix 'pdf': undeclared identifier - h2_c2.c(498) #268

Closed nono303 closed 1 year ago

nono303 commented 1 year ago

Hi @icing, It seems that there is a var name error in 2.0.23

diff --git "a/mod_http2/h2_c2.c" "b/mod_http2/h2_c2.c"
index 13567eb..a955200 100644
--- "a/mod_http2/h2_c2.c"
+++ "b/mod_http2/h2_c2.c"
@@ -495,7 +495,7 @@ static apr_status_t http2_get_pollfd_from_conn(conn_rec *c,
     }
 #else
     (void)c;
-    (void)pdf;
+    (void)pfd;
     (void)ptimeout;
 #endif /* H2_USE_PIPES */
     return APR_ENOTIMPL;
icing commented 1 year ago

Ooops, the code part that gets only build on Windows. Sorry.

Can you check if master now works for you?

nono303 commented 1 year ago

Thx for your reactivity! fcdca9e now compile fine on windows. will install & test it ASAP ;)

icing commented 1 year ago

Thanks for verifying. Just released v2.0.24.