search

icing / mod_h2

HTTP/2 module for Apache httpd
https://icing.github.io/mod_h2/
Apache License 2.0
256 stars 41 forks source link

Allowed number of HTTP/2 continuation frames #279

Open mkauf opened 7 months ago

mkauf commented 7 months ago

nghttp2 1.61.0 limits the number of HTTP/2 continuation frames and provides the new function nghttp2_option_set_max_continuations(). By default, 8 continuation frames are allowed.

Envoy increased the value to 1024 in this commit: https://github.com/envoyproxy/envoy/commit/7d0c5220cf28a4c77d1db92b193ba2cb9c40b3f0

Are 8 HTTP/2 continuation frames enough? Should the value be part of the configuration, or could mod_h2 calculate a value based on LimitRequestLine, LimitRequestFields and LimitRequestFieldSize ?

icing commented 7 months ago

Since mod_h2 now RSTs the stream after 100 incoming headers exceeding the limit, we could safely raise the number of frames. Some people, I learned, work with really huge headers.