icing / mod_md

Let's Encrypt (ACME) in Apache httpd
https://icing.github.io/mod_md/
Apache License 2.0
335 stars 27 forks source link

Feature Request: Add challenge-teardown to MDMessageCmd #295

Closed whereisaaron closed 2 years ago

whereisaaron commented 2 years ago

Feature request to add a challenge-teardown:<type>:<domain> to MDMessageCmd.

MDMessageCmd can be used to set up e.g. temporary DNS records for a DNS01 challenge when the challenge-setup message is received:

challenge-setup:<type>:<domain>

However there is no corresponding message to tear down the challenge, e.g. delete the temporary DNS records for a DNS01 challenge, e.g.

challenge-teardown:<type>:<domain>

The renewed or installed MDMessageCmd messages could be used to do the tear-down, but the don't include the challenge type, so the MDMessageCmd executable has to remember what challenges of what type it has set-up. If would enable more state-less message handling if there were an explicit challenge-teardown message.

whereisaaron commented 2 years ago

MDChallengeDns01 has explicit setup and teardown calls so my use case above is not a good one. However I still think it would be better symmetry if MDMessageCmd had both setup and teardown messages.

whereisaaron commented 2 years ago

Closing as I don't actually have a use case for this feature request, and MDMessageCmd challenge-setup is called after a challenge has been set-up.