search

ickc / pantable

CSV Tables in Markdown: Pandoc Filter for CSV Tables
https://ickc.github.io/pantable/
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

Feature/backports.csv #22

Closed ickc closed 7 years ago

ickc commented 7 years ago

@reenberg, I'm "stealing" this to check how well it works. Thanks.

reenberg commented 7 years ago

I made an attempt at fixing the tests. Now they all pass for py2 and py3.

I basically changed all the string to be unicode in py2 by adding u in front of all the strings, which should have no effect in py3(?)

I also fixed a division issue that made some tests fail in py2 due to the difference with py2 and py3 division.

And i re-added the str() around the include parameter in read_data so that the test that tries to read from True doesn't fail.

However travis-ci still fail for all py3. make test didn't report any error here when running in a py3 virtual environment.

reenberg commented 7 years ago

Ah make test doesn't run pep8.. Did not notice you had to run make testFull in order to get that.

Opps, two debug lines made it into the commit :(

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2c27ed87f1ba217452f5f22cd58c40bc18d8a407 on reenberg:feature/backports.csv into f7fd46f2eb582d815b25edc9bc6250bb709541ce on ickc:develop.

ickc commented 7 years ago

I added some notes on pasteurize in #23, which will be merged soon and show up in pantable/CONTRIBUTING.md at master · ickc/pantable.

ickc commented 7 years ago

Merging to another branch and I'll refactor this.