search

ickc / pantable

CSV Tables in Markdown: Pandoc Filter for CSV Tables
https://ickc.github.io/pantable/
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

TravisCI fails for Py3.3 #29

Closed reenberg closed 7 years ago

reenberg commented 7 years ago

With the introduced dependency on setuptools>=20.6.8 the travis build for python 3.3 fails, because the travis python 3.3 virtual environment doesn't contain a new enough setuptools:

[...]
    AssertionError: Setuptools version 20.6.8 or heigher is required.  Updated it using `pip install -U setuptools`.
[...]
reenberg commented 7 years ago

Sure thing. The virtual environment for Py3.3 contains

mock (2.0.0) nose (1.3.7) numpy (1.11.1) pbr (1.10.0) pip (9.0.1) py (1.4.31) pytest (2.9.2) setuptools (18.0.1) six (1.10.0) wheel (0.29.0)

ickc commented 7 years ago

Thanks! Sorry I didn't read this until today (the big day that pandoc 2.0 is released so I have to come checking).

Next time you can use Closing Issues via Pull Requests.

reenberg commented 6 years ago

@ickc; I thought I did, but it seems that I got the reference wrong or something?

I had "This fixes pantable/#29" in the commit message, and as you see above, it also picked up the reference to this issue : "reenberg added a commit to reenberg/pantable that referenced this issue 21 days ago"... So don't get why it didn't close this when you merged it.

ickc commented 6 years ago

I guess it was the extra “pantable/“. You can just refer to #29 since it is the same repo.

ickc commented 6 years ago

By the way, you could file an issue to GitHub so that it might becomes smarter. ;)