search

ickc / pantable

CSV Tables in Markdown: Pandoc Filter for CSV Tables
https://ickc.github.io/pantable/
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

Add support to include an excel file (.xls or .xlsx) directly #37

Closed gepcel closed 3 years ago

gepcel commented 6 years ago

I like the feature of include a .csv file. But for people heavily depends on excel files, it would be nice to be able to include an MS Excel file. Here's this.

To simplify reading, I used pandas. I think it's not a good idea to make pandas as a must requirement. So for people who don't work with excel, the filter works just as before, though the test may not pass without pandas installed (maybe skip excel test if pandas not exist?).

gepcel commented 6 years ago

Don't know the reason of failure, help needed.

ickc commented 3 years ago

Sorry, I should've review this much earlier.

Eventually I'll add support to this, but the current priority would be #51 which requires major rewriting.

Also I'd classify pandas as an optional dependency. I uses it almost every day but it is not something I want to impose on the others.

Lastly, I'd not commit binaries to this repo and I know how to include a test there without doing so.