ickc / pantable

CSV Tables in Markdown: Pandoc Filter for CSV Tables
https://ickc.github.io/pantable/
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

Add missing dependency yaml to requirements.txt #47

Closed alerque closed 4 years ago

alerque commented 4 years ago

Imported in pantable2csv.py

ickc commented 4 years ago

panflute depends on YAML so depending on panflute would automatically depends on YAML.

alerque commented 4 years ago

Please reconsider this. Yes the panflute package also depends on YAML because it calls it, but this package's code also imports and uses yaml directly. If you were only calling a panflute function and yaml was getting loaded incidentally to that it would be okay to leave out the dependency (and let the other project pin versions if necessary). As it is this project should be calling it out as a dependency and noting which version(s) it is compatible with when necessary.

What you are suggesting is called a Transitive dependency ... except that it isn't rightly even transitive in this case because your first party code here is what imports yaml.

ickc commented 4 years ago

Ok, done!

alerque commented 4 years ago

Thanks.