search

ickerio / factions

Highly customizable, lightweight and fully featured factions mod for the Fabric loader in Minecraft
MIT License
25 stars 28 forks source link

Anti x-ray mod incompatibility #61

Open 42Willow opened 2 years ago

42Willow commented 2 years ago

I am using 1.19 Minehut fabric with this mod and when travelling to a claimed area via nether portal the portal loads endlessly.

BlueZeeKing commented 2 years ago

Can you post the logs?

BlueZeeKing commented 2 years ago

Also, if you join the discord we can help you much more easily

42Willow commented 2 years ago

Also, if you join the discord we can help you much more easily

sorry I don't use discord

Can you post the logs?

which logs?

42Willow commented 2 years ago

the server logs don't contain any errors when I go through the portal, it just doesn't load. I have to leave and rejoin

ickerio commented 2 years ago

I've experienced this too but I just attributed it to a bug in 1.19. So if you remove the factions mod you no longer get this bug? If that's the case then my only thoughts are the onMove mixin we have.

42Willow commented 2 years ago

I've experienced this too but I just attributed it to a bug in 1.19. So if you remove the factions mod you no longer get this bug? If that's the case then my only thoughts are the onMove mixin we have.

I installed the mod today and haven't had the problem before today for a few weeks so I think that's the problem.

PyPylia commented 2 years ago

Testing in a vanilla environment I cannot recreate this issue. Were you using any mods on the server and/or client? If so can you list them, as it might be an issue with a mod such as Lithium or Starlight. Additionally, more information in general would be helpful, such as if radar was enabled, if the players affected are in a faction or not, if the chunks they're entering are overworld or nether, and claimed by their own faction, another faction or wilderness, etc... My initial thought is that for whatever reason, the lighting thread on the client is hanging (as talking with other people experiencing this issue has revealed that the player entity appears on the other side for other players, and the affected player can still hear sounds even while the 'Loading Terrain' message is present), as to what causes this is unknown as I cannot trigger it, and exceptions would cause a log message and/or kick/crash the player. I believe it'd be due to lighting as if the main thread had hung, the game would freeze altogether, or if it could not load the chunks, sounds wouldn't work.

42Willow commented 2 years ago

Testing in a vanilla environment I cannot recreate this issue. Were you using any mods on the server and/or client? If so can you list them, as it might be an issue with a mod such as Lithium or Starlight. Additionally, more information in general would be helpful, such as if radar was enabled, if the players affected are in a faction or not, if the chunks they're entering are overworld or nether, and claimed by their own faction, another faction or wilderness, etc... My initial thought is that for whatever reason, the lighting thread on the client is hanging (as talking with other people experiencing this issue has revealed that the player entity appears on the other side for other players, and the affected player can still hear sounds even while the 'Loading Terrain' message is present), as to what causes this is unknown as I cannot trigger it, and exceptions would cause a log message and/or kick/crash the player. I believe it'd be due to lighting as if the main thread had hung, the game would freeze altogether, or if it could not load the chunks, sounds wouldn't work.

Factions config: { "version": 2, "basePower": 30, "memberPower": 20, "claimWeight": 5, "maxFactionSize": -1, "safeTicksToWarp": 1000, "powerDeathPenalty": 10, "ticksForPower": 12000, "ticksForPowerReward": 1, "requiredBypassLevel": 2, "home": "CLAIMS", "radarEnabled": true, "friendlyFireEnabled": false, "chatModificationEnabled": true, "factionSafe": "ENABLED", "factionSafeDouble": true }

Installed mods:

BlueZeeKing commented 2 years ago

I tested it myself and it worked fine. I used all the same mods except for Fabric Proxy Lite because that requires velocity, which I'm not going to install for a quick test. Can you test without the factions mod? and if so is it still broken?

PyPylia commented 2 years ago

I just did some more testing, attempting to control every variable by running it as a standard server instead of in my standard dev environment. I also used velocity and even installed clientside mods such as Sodium and Starlight to see if they had an effect, and so far I am still unable to recreate the issue. Even attempting to edit the factions data files to create invalid states does nothing.

42Willow commented 2 years ago

Thank you for trying to reproduce this issue, I will uninstall all the mods apart from factions but it is definitely still occurring image

Edit: I have uninstalled the mods and it doesn't seem to be occurring anymore, I will reopen the issue if it happens again.

PyPylia commented 2 years ago

A couple more questions I have:

  1. Do you have any clientside mods installed, if so which ones?
  2. Is the portal within the spawn chunks, or outside?
  3. By which faction is the chunks your portal is in claimed by (Aka entry side is my own, exit side is wilderness, or another faction, etc...)
  4. Is radar enabled?
  5. Are sounds enabled?
  6. Is bypass enabled?
  7. Are you an operator?
  8. Has velocity been changed from its default settings (other than the settings required to get FabricProxy-Lite to work).
  9. Is there any error within the client or velocity logs?
PyPylia commented 2 years ago

Ah, I only saw your edit just now, try running the server without factions for a bit, but with those other mods and see if the issue arises again. It'd be useful to know if it is caused by another mod, or caused by a conflict between another mod and the factions mod.

42Willow commented 2 years ago

It seems to be caused by this mod --> Anti x-ray (https://github.com/DrexHD/AntiXray)

PyPylia commented 2 years ago

And it only occurs with both mods?

42Willow commented 2 years ago

And it only occurs with both mods?

yes

PyPylia commented 2 years ago

Can you send the config file you used for Anti-Xray when this issue occurred?

42Willow commented 2 years ago

Can you send the config file you used for Anti-Xray when this issue occurred?

Sorry for the late reply, here is the config file I used for Anti-Xray:

# Default configuration file for Fabric AntiXray mod by DrexHD

# Default values
enabled = false

# World specific values
[overworld]
enabled = true
engineMode = 1
maxBlockHeight = 256
updateRadius = 2
lavaObscures = false
hiddenBlocks = ["copper_ore", "deepslate_copper_ore", "raw_copper_block", "gold_ore", "deepslate_gold_ore", "raw_gold_block", "iron_ore", "deepslate_iron_ore", "raw_iron_block", "coal_ore", "deepslate_coal_ore", "lapis_ore", "deepslate_lapis_ore", "mossy_cobblestone", "obsidian", "chest", "diamond_ore", "deepslate_diamond_ore", "redstone_ore", "deepslate_redstone_ore", "clay", "emerald_ore", "deepslate_emerald_ore", "ender_chest"]
replacementBlocks = ["stone", "deepslate"]

[the_nether]
enabled = true
engineMode = 1
maxBlockHeight = 128
updateRadius = 2
lavaObscures = true
hiddenBlocks = ["ancient_debris", "nether_quartz_ore", "nether_gold_ore"]
replacementBlocks = ["netherrack"]

(I only changed the engine mode to 1 instead of 2 for the overworld)

42Willow commented 1 year ago

I'm not using the anti xray mod anymore so I don't know if it's still reproduceable.. Should I close this issue as not many people use that mod?