search

icl-utk-edu / heffte

BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

CUDA_NVCC_FLAGS variable not honored by CMakeLists.txt #2

Closed luszczek closed 1 year ago

luszczek commented 1 year ago

After configuring heFFTe, the option CUDA_NVCC_FLAGS is listed as output but is not passed to the nvcc compiler.

For example, cmake invocation: cmake -B /path/to/build -D Heffte_ENABLE_CUDA=On -D CUDA_NVCC_FLAGS=--no-such-flag /path/to/heffte/source/code ; cd /path/to/build ; make finishes successfully even though CUDA_NVCC_FLAGS is set to invalid value.

The only way to pass flags to CUDA's compiler I could use was through the CMake's standard CMAKE_CUDA_FLAGS variable.

mkstoyanov commented 1 year ago

That was a leftover from when we transition to CUDA as a CMake language. Fixing now.

Thanks for reporting!