search

icl-utk-edu / heffte

BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Fix CMake: FFTW Threads #55

Open ax3l opened 2 weeks ago

ax3l commented 2 weeks ago

Fix a build issues on Linux in Conda-Forge in which pthreads showed unresolved library paths from FFTW threads variants: https://github.com/conda-forge/staged-recipes/pull/26633

Similar logic as in #47, but for (p)threads.

ax3l commented 2 weeks ago

@mkstoyanov this one is ready for review now :)

mkstoyanov commented 2 weeks ago

@ax3l I'm currently on vacation, so I'm responding with a delay.

I don't like changing the default behavior on system with both threads and openmp, which should be an easy fix.

I also don't like superfluous code for features that aren't supported anyway. But other than that, this looks OK.