gcongiu
commented
11 months ago Hi Milian,
We recently merged commit b514860b3 that fixed a problem with an attribute size in libpfm4. I am not sure this might be the problem but could you try reverting the following commit to see if it works again for you?
commit b514860b30cfa6edb4379a580c65948058646eab Author: Josh Minor @.***> Date: Wed Sep 13 09:53:49 2023 -0500
Set size of perf_attr_struct prior to getting pfm encoding
Signed-off-by: Josh Minor ***@***.***>diff --git a/src/components/perf_event/pe_libpfm4_events.c b/src/components/perf_event/pe_libpfm4_events.c index a4f8e5d4b..859f10c8a 100644 --- a/src/components/perf_event/pe_libpfm4_events.c +++ b/src/components/perf_event/pe_libpfm4_events.c @@ -191,6 +191,9 @@ static struct native_event_t *allocate_native_event( perf_arg.attr=&ntv_evt->attr; perf_arg.fstr=&event_string;
- // set the size of the perf attr struct before getting pfm encoding
- ntv_evt->attr.size = sizeof(struct perf_event_attr);
-
/* use user provided name of the event to get the */ /* perf_event encoding and a fully qualified event string */ ret = pfm_get_os_event_encoding(name,
Thank you, Giuseppe
On 26 Nov 2023, at 10:51, Milian Wolff @.***> wrote:
A simple call to PAPI_ipc fails on my Thinkpad P1 Gen4 laptop, whereas this used to work fine on my older laptop and also on my workstation with an AMD Cpu. It is not yet a hybrid intel CPU, and I have elevated my perf privileges (perf stat works just fine).
include
include
struct Ipc { static Ipc measure() { Ipc data; int ret = PAPI_ipc(&data.realTime, &data.processTime, &data.instructions, &data.ipc); if (ret != 0) { std::cerr << "IPC measurement failed with code " << ret << ": " << PAPI_strerror(ret) << std::endl; }
return data; } void print(const char* label) const { std::cout << label << "\n\trealtime elapsed: " << realTime << ", process time elapsed: " << processTime << "\n\tinstructions executed: " << instructions << ", cycles: " << (instructions / ipc) << ", IPC: " << ipc << "\n"; } float realTime = 0; float processTime = 0; long long instructions = 0; float ipc = 0;};
int main() { Ipc::measure().print("test"); return 0; } Compiled with:
$ g++ -g -O2 test.cpp -lpapi -o test_papi $ ./test_papi IPC measurement failed with code -7: Event does not exist test realtime elapsed: 0, process time elapsed: 0 instructions executed: 0, cycles: -nan, IPC: 0 With strace I can see:
perf_event_open({type=PERF_TYPE_HARDWARE, size=0 / PERF_ATTRSIZE??? /, config=PERF_COUNT_HW_INSTRUCTIONS, sample_period=0, sample_type=0, read_format=0, precise_ip=0 / arbitrary skid /, ...}, 0, -1, -1, 0) = 3 close(3) = 0 perf_event_open({type=PERF_TYPE_HARDWARE, size=0 / PERF_ATTRSIZE??? /, config=PERF_COUNT_HW_INSTRUCTIONS, sample_period=0, sample_type=0, read_format=0, precise_ip=0 / arbitrary skid /, exclude_guest=1, ...}, 0, -1, -1, 0) = 3 close(3) = 0 When I instead run strace perf stat -e instructions on some binary I see:
perf_event_open({type=PERF_TYPE_HARDWARE, size=0x88 / PERF_ATTRSIZE??? /, config=PERF_COUNT_HW_INSTRUCTIONS, sample_period=0, sample_type=PERF_SAMPLE_IDENTIFIER, read_format=PERF_FORMAT_TOTAL_TIME_ENABLED|PERF_FORMAT_TOTAL_TIME_RUNNING, disabled=1, inherit=1, enable_on_exec=1, precise_ip=0 / arbitrary skid /, exclude_guest=1, ...}, 4762, -1, -1, PERF_FLAG_FD_CLOEXEC) = 3 ... read(3, "\202T \0\0\0\0\0\250\306\6\0\0\0\0\0\250\306\6\0\0\0\0\0", 24) = 24 close(3) = 0 My system:
inxi -GSC -xx System: Host: agathemoarbauer Kernel: 6.6.2-arch1-1 arch: x86_64 bits: 64 compiler: gcc v: 13.2.1 Desktop: KDE Plasma v: 5.27.9 tk: Qt v: 5.15.11 wm: kwin_x11 dm: SDDM Distro: Arch Linux CPU: Info: 8-core model: 11th Gen Intel Core i7-11850H bits: 64 type: MT MCP arch: Tiger Lake rev: 1 cache: L1: 640 KiB L2: 10 MiB L3: 24 MiB Speed (MHz): avg: 969 high: 3506 min/max: 800/4800 cores: 1: 800 2: 800 3: 800 4: 800 5: 800 6: 800 7: 800 8: 3506 9: 800 10: 800 11: 800 12: 800 13: 800 14: 800 15: 800 16: 800 bogomips: 79888 Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx — Reply to this email directly, view it on GitHub https://github.com/icl-utk-edu/papi/issues/126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGP5MQDL7IO4UKKWBJK6MDYGMGJ7AVCNFSM6AAAAAA72XNTUSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTAOJXGQ2TMNY. You are receiving this because you are subscribed to this thread.
milianw
adanalis
A simple call to
PAPI_ipcfails on my Thinkpad P1 Gen4 laptop, whereas this used to work fine on my older laptop and also on my workstation with an AMD Cpu. It is not yet a hybrid intel CPU, and I have elevated my perf privileges (perf statworks just fine).Compiled with:
With strace I can see:
When I instead run
strace perf stat -e instructionson some binary I see:My system: