Closed neil-lindquist closed 9 months ago
Since #143 is merged, can I drop the Draft label? Locally I rebased this to include the changes that I added to #143. I need to double-check that code before I push it.
Yes, the draft status was just waiting for #143.
I rebased this on top of the current master with the merged-in #143. There were some merge conflicts, which hopefully I managed correctly. (I did them twice and compared to make sure.)
This PR continues the work of #143 to add support for nonuniform tile sizes, device distributions, and grid orders to more testers. I also made a couple of related warning messages more consistent. However, I didn't change the defaults of
run-tests.py
to test the added configurations.The change is largely realized by refactoring the matrix creation logic into a helper function. This helps reduce the amount of duplicate code, which actually reduces the line count and the executable size a little bit.
Other improvements
henorm
andsynorm
when tiles are nonuniformtest/scalapack_support_routines.hh
since it's no longer useddev-dist
param was flipped to matchslate/func.hh
This PR ended up longer than intended. I'd probably suggest starting with
test/test_util.hh
,test/matrix_util.hh
, andtest/matrix_util.cc
. Also, the norm testers have some big indent changes, so I'd suggest reviewing that diff with "ignore whitespace" enabled.Diff w/ #143