Closed jakubd closed 9 years ago
This means that name resolution has failed (maybe the domain name isn't registered anymore).
I get that-- but why output the tracebacks to the user if this is expected in a test? It gives the impression that something is broken. When an HTTP GET 404's we don't output that to the user in a traceback, why is this done in the TLS test?
Raising the exception is not necessary in this case since the textual representation is already recorded in the results file. I'm removing the part that raises the exception. This makes the output cleaner.
The TLS certificate requests experiment constantly produces constant traceback output when you run centinel-dev. I think this is related to the fact that not all the TLS requests go through (ie name doesn't resolve, connection doesn't connect cleanly etc) which is expected in an experiment but I don't think we should output tracebacks to the users if this functionality is expected.
This is a dump of what I am talking about:
In the above example, everything runs fine but the tracebacks give the impression that the test doesn't work and I would forgive someone for Ctrl-C'ing out of the test assuming something went wrong. Maybe a better approach would be to summarize the output into a debug log and not output to standard out?