search

iclems / iOS-htmltopdf

MIT License
305 stars 79 forks source link

Added Block Syntax #12

Closed martinjuhasz closed 10 years ago

martinjuhasz commented 10 years ago

i added block syntax and updated the demo to reflect this changes.

iclems commented 10 years ago

Hey there,

I love the idea of moving to Blocks here. Just adding a few comments of things I think it would be nice to do also before merging

Thanks!

iclems commented 10 years ago

In fact it's just great! Any idea of other nice-to-have?

martinjuhasz commented 10 years ago

f.e. for me, it's not really necessary to write the pdf to a file, but currently there is no way without it. for me, it would be much better to just get the nsdata of the pdf to avoid dealing with naming a pdf right and deleting it after the job has finished (i always need to generate a new pdf, show it in a webview, which could be done directly with nsdata, and attach it to an email, which also is done directly with NSData).

iclems commented 10 years ago

What would you think of this? https://github.com/iclems/iOS-htmltopdf/pull/14

Basically enables you not to provide a file path

iclems commented 10 years ago

My guess is that the success callback block could also be called with the NSData value as argument, what do you think?