search

icloud-photos-downloader / icloud_photos_downloader

A command-line tool to download photos from iCloud
MIT License
7.06k stars 562 forks source link

pass log_level to pyicloud library #1006

Open sdebruyn opened 5 days ago

sdebruyn commented 5 days ago

Probably resolves #123

I would also like to see logs from the pyicloud library.

AndreyNikiforov commented 5 days ago

Were you able to solve any problem with extra logging yet (or working on something where it helps)?

What does pyicloud expose with default DEBUG level? Does that extra info (if any) improve user experience for everybody using default logging setting?

sdebruyn commented 5 days ago

One of the things it tells you is if found a cookie or not, which might be useful. E.g. in the case I had in #1005

AndreyNikiforov commented 4 days ago

Does default DEBUG level changes experience for user who do not need extra logs?

sdebruyn commented 4 days ago

Probably, but then again, should the default logger level really be DEBUG? Most application would put this on info/warn

AndreyNikiforov commented 4 days ago

Probably, but then again, should the default logger level really be DEBUG? Most application would put this on info/warn

I agree that default logging set to DEBUG feels off-balance. Should we change it then? Probably opening a can of worms now as most of output today is done through logs and there are certain expectations for it (e.g. what is output by default).