Open iowk opened 6 days ago
Thanks for reporting. Yes, .part files will be left on the drive if app crashes. A number of thoughts on the subject:
Seems that simple try-catch wrapping and silent file deletion may cover most probable case (space issues). It will not hurt re-auth hypothetical case.
Overview
If downloading fails because of insufficient disk space,
.part
file remains and is not removed.Steps to Reproduce
IOError while writing...
Expected Behavior
The
.part
file should be deleted after downloading fails.Actual Behavior
The
.part
file remains.Context
I think we can add a try-finally block in
download_response_to_path
to remove the.part
file on error.