search

icnocop / cuite

Coded UI Test enhanced Framework
Microsoft Public License
52 stars 29 forks source link

Issue #83 #84

Closed aannenko closed 8 years ago

aannenko commented 8 years ago

Three new members are added to the ControlBase class. They allow to work with control's visibility.

aannenko commented 8 years ago

I also added a TryGetClickablePointMethod so that it could be used not only implicitly inside the visibility related methods.

FantasticFiasco commented 8 years ago

@icnocop Any comments?

icnocop commented 8 years ago

There are a lack of tests. :wink: Other than that, thank you for the pull request, @aannenko! :smile:

FantasticFiasco commented 8 years ago

You should also update the changelog document and add your name there.

aannenko commented 8 years ago

Well, I don't have any idea on how to test a WPF part of this... Sorry... Can you help me a bit with this? What do I have to write? Tests for HTML and... something else?

FantasticFiasco commented 8 years ago

I'll see what I can do with it, sorry for the long sleep.

FantasticFiasco commented 8 years ago

@aannenko I took the liberty to add your name to CHANGELOG.md. Because of that I had to create a new PR and close this one. Hope you don't mind...

@icnocop I don't have permissions to publish package on NuGet, can you do that?

@aannenko Hope your project is going well and that you get any benefit from using CUITe. Thank you very much for your interest and contributions to this project!

icnocop commented 8 years ago

@FantasticFiasco, NuGet packages are automatically published during the build. :)

FantasticFiasco commented 8 years ago

@icnocop Oh, nice! The PR was successful on AppVeyor, but I didn't manage to get master through even though I tried twice.

aannenko commented 8 years ago

@FantasticFiasco Thanks a lot! :)

icnocop commented 8 years ago

@FantasticFiasco , I just re-invoked the build on the commit and it succeeded. It failed last time because of an unstable test. The unstable test is Sut.HtmlTest.HtmlControlTests.SetText_OnTelerikASPNETComboBox_SelectsItemByText which actually tests against a website in production which isn't very ideal. So, as usual the test succeeds the second time it is run. :smirk:

FantasticFiasco commented 8 years ago

@icnocop Business as usual :smile: