Closed bbist closed 1 year ago
Hello @bbist,
For now, the new APIs you've proposed look good to me. You may proceed with those APIs design.
One thing I want to comment is how about clarifying the g1 point by using bls12-381-g1
instead of bls12-381
in ecAdd()
and ecSalarMul()
? As you may know, we've already used that term, bls12-381-g1
, in aggregate()
, so it would be aligned with the previous usage.
Additionally, please note that you should write your code based on the base
branch code, not the master
, since this kind of APIs addition is for common part, not only for ICON. See the https://github.com/icon-project/goloop#contribution-guidelines.
Thanks @sink772 for the suggestions. Will make the changes, and submit a PR to the base branch.
Following the discussion in PR https://github.com/icon-project/goloop/pull/148 to support AltBN128 curve on ICON, we've decided to follow the suggestions from
goloop
core team to expose BLS12-381 curve operations via Context API using existing Java BLST JNI library. This is part of a set of enhancements necessary on ICON blockchain for supporting zkSNARKs.This issue will track current and future changes related to BLS12-381 curve operations exposed via Context API.