search

icon-project / icon-bridge

The centralized bridge of ICON
Apache License 2.0
21 stars 15 forks source link

feat(btp): Extend deployment script functionality to support different chain configs #641

Open andrii-kl opened 1 year ago

andrii-kl commented 1 year ago

Overview

Extend deployment script functionality to support different chain configs

New structure that I suggest to use:

devnet/docker/icon-bsc/scripts ->

/deploysc.sh
... /config (new folder) -> icon-lisb-bsc-test.sh icon-bsc-main.sh icon-lisb-snow-arctic.sh icon-snow-main.sh ...... ......

How it works now

To deploy we manually edit a configuration file of a deployment script originally written for icon-bsc testnet. To be specific, we change network id, rpc endpoint and coins info on config.sh file.

Story

As a [developer], I want [ to run deployment script with passing path to my chains config file ] so that [ deploy everything without any manual changes in the config file ]

CyrusVorwald commented 1 year ago

I agree about moving this to a new folder, but would much prefer that we transition away from bash scripts. Take a look at how Wormhole uses Tilt and Kubernetes. I think we should do pretty much the same thing.